Skip to content

Added IFeature type. Fixed memory leakage for Features. #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Added IFeature type. Fixed memory leakage for Features. #294

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb1b03b
Added IFeature type. Fixed memory leakage for `Feature`s.
evetion Apr 20, 2022
fb6b05e
Update version
evetion Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/base/display.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ function Base.show(io::IO, gfd::AbstractGeomFieldDefn)::Nothing
return nothing
end

function Base.show(io::IO, feature::Feature)::Nothing
function Base.show(io::IO, feature::AbstractFeature)::Nothing
if feature.ptr == C_NULL
print(io, "NULL Feature")
return nothing
Expand Down
6 changes: 3 additions & 3 deletions src/base/iterators.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
function Base.iterate(
layer::AbstractFeatureLayer,
state::Integer = 0,
)::Union{Nothing,Tuple{Feature,Int64}}
)::Union{Nothing,Tuple{IFeature,Int64}}
layer.ptr == C_NULL && return nothing
state == 0 && resetreading!(layer)
ptr = GDAL.ogr_l_getnextfeature(layer.ptr)
return if ptr == C_NULL
resetreading!(layer)
nothing
else
(Feature(ptr), state + 1)
(IFeature(ptr), state + 1)
end
end

Base.eltype(layer::AbstractFeatureLayer)::DataType = Feature
Base.eltype(layer::AbstractFeatureLayer)::DataType = IFeature

Base.IteratorSize(::Type{<:AbstractFeatureLayer}) = Base.SizeUnknown()

Expand Down
Loading