[breaking] switch from Base.convert to GeoInterface.convert #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeesian
changed the title
Owner
|
Added "[breaking]" to the title so we might get reminded of it when tagging for the next release: v0.9.4...master |
Collaborator
Author
|
Thanks, yes I also added a "breaking" label that helps with querying PRs. What do you think, should we tag 0.10 now? Would be nice to have GDAL 3.6 available. |
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change.
For background see JuliaGeo/GeoInterface.jl#66. Brought up in #189 (comment).
Soon JuliaGeo/GeoInterface.jl#85 will provide extra options for conversion, though this doesn't help ArchGDAL as much, since you always convert to
IGeometryanyway. And it is not breaking so no need to wait for that.After this is in, shall we tag v0.10?