feat(totp): add timeStep to generate() return value#750
Draft
Conversation
cef6bf8 to
f3a7ce2
Compare
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 1109 1119 +10
Branches 220 199 -21
=========================================
+ Hits 1109 1119 +10 ☔ View full report in Codecov by Sentry. |
Bundle ReportChanges will increase total bundle size by 5.81kB (0.54%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @otplib/preset-v11Assets Changed:
view changes for bundle: otplibAssets Changed:
view changes for bundle: @otplib/totpAssets Changed:
view changes for bundle: @otplib/v12-adapterAssets Changed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeStepto TOTP generation function return valuesgenerate()andgenerateSync()to return{ token, timeStep }instead of string{ token, timeStep }Breaking Changes
Direct TOTP API usage:
const token = await generate({ secret, crypto })const { token, timeStep } = await generate({ secret, crypto })Backward compatible APIs (no breaking changes):