Add replace(), __getitem__, and __iter__ to pipeline#157
Open
dhdaines wants to merge 2 commits intoyeraydiazdiaz:masterfrom
Open
Add replace(), __getitem__, and __iter__ to pipeline#157dhdaines wants to merge 2 commits intoyeraydiazdiaz:masterfrom
dhdaines wants to merge 2 commits intoyeraydiazdiaz:masterfrom
Conversation
7fa936b to
5ddde13
Compare
yeraydiazdiaz
previously approved these changes
Sep 8, 2024
Owner
|
Thanks again. Could you add entries in the Changelog under "Unreleased"? The same applies to the other PRs. Happy to merge when the pipelines pass. |
Contributor
Author
|
Ah! I forgot to run tox! Fixed now. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 96.02% 95.95% -0.07%
==========================================
Files 48 48
Lines 3171 3217 +46
==========================================
+ Hits 3045 3087 +42
- Misses 126 130 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
14f9e58 to
66ad327
Compare
Contributor
Author
|
Should be good now - it made sense to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows one to more easily find registered functions (such as the broken language trimmers) in a pipeline and replace them (with less broken ones). Fixes #155