Skip to content

Refactor so Format::Phantom yields PhantomData#278

Merged
archaephyrryx merged 2 commits intomainfrom
archaephyrryx/phantomdata-for-phantom
Nov 28, 2025
Merged

Refactor so Format::Phantom yields PhantomData#278
archaephyrryx merged 2 commits intomainfrom
archaephyrryx/phantomdata-for-phantom

Conversation

@archaephyrryx
Copy link
Contributor

No description provided.

/// Local choice of what type to embed as the parameter to make concrete type-instances we can pass into
/// `size_of` and `align_of` methods.
type VecFiller = u8;
type Cement = u32;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Cement? 🤓

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's something that fills in the gaps and makes something 'concrete', bit of a pun but because it applies to more than just Vec now it seems reasonable to change the name

Copy link
Contributor

@mikeday mikeday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks fine.

@archaephyrryx archaephyrryx merged commit 4a0370c into main Nov 28, 2025
1 check passed
@archaephyrryx archaephyrryx deleted the archaephyrryx/phantomdata-for-phantom branch November 28, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants