Add partial body to failing uses of bodyContains for debugging#1900
Merged
MaxGabriel merged 2 commits intomasterfrom Jan 26, 2026
Merged
Add partial body to failing uses of bodyContains for debugging#1900MaxGabriel merged 2 commits intomasterfrom
MaxGabriel merged 2 commits intomasterfrom
Conversation
Member
Author
|
Tested this locally just by modifying a test in yesod-test's own suite. Example error messages: |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
statusIsfails and the content is UTF-8 (i.e. like, not a giant JPEG or something), we print a partial body to aid in debugging. For small bodies this is sometimes sufficient to print the whole thing, and especially is helpful to indicate a general direction if the body is way off (e.g. the body for a 500 vs a 200).This PR applies that same helpful error message to failing
bodyContainsandbodyNotContainscalls.A potential variant would be to print the full body, which
bodyEqualsdoes. That could be more helpful, but there is also some risk thatbodyContainsandbodyNotContainsare being used because it is an enormous response body, and printing the full thing would dump a lot of content.Before submitting your PR, check that you've:
@sincedeclarations to the Haddocks for new, public APIsAfter submitting your PR: