feat: check latest nonce response to know when to cut the connection

Author: uri-99

batcher/aligned-sdk/src/communication/batch.rs

@@ -14,8 +14,8 @@ const RETRIES: u64 = 10;
 const TIME_BETWEEN_RETRIES: u64 = 10;
 
 pub fn process_batcher_response(
-    batch_inclusion_data: BatchInclusionData,
-    verification_data_commitment: VerificationDataCommitment,
+    batch_inclusion_data: &BatchInclusionData,
+    verification_data_commitment: &VerificationDataCommitment,
 ) -> Result<AlignedVerificationData, errors::SubmitError> {
     debug!("Received response from batcher");
     debug!(
@@ -24,11 +24,11 @@ pub fn process_batcher_response(
     );
     debug!("Index in batch: {}", batch_inclusion_data.index_in_batch);
 
-    if verify_proof_inclusion(&verification_data_commitment, &batch_inclusion_data) {
+    if verify_proof_inclusion(verification_data_commitment, batch_inclusion_data) {
         Ok(
             AlignedVerificationData::new(
-                &verification_data_commitment,
-                &batch_inclusion_data,
+                verification_data_commitment,
+                batch_inclusion_data,
             )
         )
     } else {

batcher/aligned-sdk/src/communication/messaging.rs

@@ -84,6 +84,7 @@ pub async fn receive(
     // Responses are filtered to only admit binary or close messages.
     let mut response_stream = response_stream.lock().await;
     let mut aligned_submitted_data: Vec<AlignedVerificationData> = Vec::new();
+    let last_proof_nonce = get_biggest_nonce(&sent_verification_data);
 
     // read from WS
     while let Some(Ok(msg)) = response_stream.next().await {
@@ -110,11 +111,16 @@ pub async fn receive(
         )?;
 
         let aligned_verification_data = process_batcher_response(
-            batch_inclusion_data_message,
-            related_verification_data,
+            &batch_inclusion_data_message,
+            &related_verification_data,
         )?;
 
         aligned_submitted_data.push(aligned_verification_data);
+        info!("Message response handled succesfully");
+
+        if batch_inclusion_data_message.user_nonce == last_proof_nonce {
+            break;
+        }
     }
 
     debug!("All message responses handled succesfully");
@@ -234,3 +240,13 @@ fn match_batcher_response_with_stored_verification_data(
 
     Err(SubmitError::InvalidProofInclusionData)
 }
+
+fn get_biggest_nonce(sent_verification_data: &Vec<NoncedVerificationData>) -> U256 {
+    let mut biggest_nonce = U256::zero();
+    for verification_data in sent_verification_data.iter() {
+        if verification_data.nonce > biggest_nonce {
+            biggest_nonce = verification_data.nonce;
+        }
+    }
+    biggest_nonce
+}

batcher/aligned-sdk/src/sdk.rs

@@ -313,9 +313,8 @@ async fn _submit_multiple(
 
         // done sequencial
         // added size check to avoid sequencial is too big
-    // chequeando el nonce del ultimo, puedo cortar la conexión cuando recibo su respuesta
-    // agregar nonce en la respuesta del batcher al sender
-    // sacar el mensaje de que la proof es una replacement
+        // done added nonce en la respuesta del batcher al sender
+        // done check last nonce to close connection.
 
     let result = async {
         let sent_verification_data = send_messages(ws_write, payment_service_addr, verification_data, max_fees, wallet, nonce).await?;