Rename dev mode var to is dev mode

maximopalopoli · maximopalopoli · commit 295b7cefa340 · 2025-11-26T17:59:47.000-03:00
diff --git a/contracts/script/deploy/AlignedProofAggregationServiceDeployer.s.sol b/contracts/script/deploy/AlignedProofAggregationServiceDeployer.s.sol
@@ -17,13 +17,13 @@ contract AlignedProofAggregationServiceDeployer is Script {
         address risc0VerifierAddress = stdJson.readAddress(config_data, ".address.risc0VerifierAddress");
         bytes32 risc0AggregationProgramImageId =
             stdJson.readBytes32(config_data, ".programs_id.risc0AggregationProgramImageId");
-        bool devMode = stdJson.readBool(config_data, ".devMode");
+        bool isDevMode = stdJson.readBool(config_data, ".isDevMode");
 
         address ownerAddress = stdJson.readAddress(config_data, ".permissions.owner");
 
         vm.startBroadcast();
 
-        AlignedProofAggregationService alignedProofAggregationService = new AlignedProofAggregationService(devMode);
+        AlignedProofAggregationService alignedProofAggregationService = new AlignedProofAggregationService(isDevMode);
 
         ERC1967Proxy proxy = new ERC1967Proxy(
             address(alignedProofAggregationService),
diff --git a/contracts/script/deploy/config/devnet/proof-aggregator-service.devnet.config.json b/contracts/script/deploy/config/devnet/proof-aggregator-service.devnet.config.json
@@ -12,5 +12,5 @@
   "permissions": {
     "owner": "0x14dC79964da2C08b23698B3D3cc7Ca32193d9955"
   },
-  "devMode": false
+  "isDevMode": false
 }
diff --git a/contracts/script/deploy/config/devnet/proof-aggregator-service.devnet.mock.config.json b/contracts/script/deploy/config/devnet/proof-aggregator-service.devnet.mock.config.json
@@ -12,5 +12,5 @@
   "permissions": {
     "owner": "0x14dC79964da2C08b23698B3D3cc7Ca32193d9955"
   },
-  "devMode": true
+  "isDevMode": true
 }
diff --git a/contracts/script/deploy/config/holesky/proof-aggregator-service.holesky.config.json b/contracts/script/deploy/config/holesky/proof-aggregator-service.holesky.config.json
@@ -11,5 +11,5 @@
   "permissions": {
     "owner": "0x97aEC5F28181abe5d2aD40dBe7FbaEe014529b7D"
   },
-  "devMode": false
+  "isDevMode": false
 }
diff --git a/contracts/script/deploy/config/holesky/proof-aggregator-service.holesky.config.stage.json b/contracts/script/deploy/config/holesky/proof-aggregator-service.holesky.config.stage.json
@@ -11,5 +11,5 @@
   "permissions": {
     "owner": "0xE3C695b73dbe27106aF4530b152de3e57456B385"
   },
-  "devMode": false
+  "isDevMode": false
 }
diff --git a/contracts/script/deploy/config/hoodi/proof-aggregator-service.hoodi.config.json b/contracts/script/deploy/config/hoodi/proof-aggregator-service.hoodi.config.json
@@ -11,5 +11,5 @@
   "permissions": {
     "owner": "0xF138043AC49a0cbB1C8fF03433B51861eA0AE927"
   },
-  "devMode": false
+  "isDevMode": false
 }
diff --git a/contracts/script/deploy/config/mainnet/proof-aggregator-service.mainnet.config.json b/contracts/script/deploy/config/mainnet/proof-aggregator-service.mainnet.config.json
@@ -11,5 +11,5 @@
   "permissions": {
     "owner": "<owner_address>"
   },
-  "devMode": false
+  "isDevMode": false
 }
diff --git a/contracts/script/deploy/config/mainnet_staging/proof-aggregator-service.mainnet.config.json b/contracts/script/deploy/config/mainnet_staging/proof-aggregator-service.mainnet.config.json
@@ -11,5 +11,5 @@
   "permissions": {
     "owner": "<owner_address>"
   },
-  "devMode": false
+  "isDevMode": false
 }
diff --git a/contracts/script/deploy/config/sepolia/proof-aggregator-service.sepolia.config.json b/contracts/script/deploy/config/sepolia/proof-aggregator-service.sepolia.config.json
@@ -11,5 +11,5 @@
   "permissions": {
     "owner": "0x771C1aB81C81A774B66C4386Eb50D6DFC8538106"
   },
-  "devMode": false
+  "isDevMode": false
 }
diff --git a/contracts/script/deploy/config/templates/proof-aggregator-service.template.config.json b/contracts/script/deploy/config/templates/proof-aggregator-service.template.config.json
@@ -11,5 +11,5 @@
   "permissions": {
     "owner": ""
   },
-  "devMode": false
+  "isDevMode": false
 }
diff --git a/contracts/script/upgrade/ProofAggregatorServiceUpgrader.s.sol b/contracts/script/upgrade/ProofAggregatorServiceUpgrader.s.sol
@@ -17,9 +17,9 @@ contract AlignedProofAggregationServiceUpgrader is Script {
             payable(stdJson.readAddress(aligned_deployment_file, ".addresses.alignedProofAggregationService"))
         );
 
-        bool devMode = stdJson.readBool(config_data, ".devMode");
+        bool isDevMode = stdJson.readBool(config_data, ".isDevMode");
 
-        AlignedProofAggregationService newProofAggregatorServiceImplementation = new AlignedProofAggregationService(devMode);
+        AlignedProofAggregationService newProofAggregatorServiceImplementation = new AlignedProofAggregationService(isDevMode);
 
         // Not link the new implementation to the proxy
         // Because this must be executed in the multisig
diff --git a/contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json b/contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json
diff --git a/contracts/src/core/AlignedProofAggregationService.sol b/contracts/src/core/AlignedProofAggregationService.sol
@@ -36,7 +36,7 @@ contract AlignedProofAggregationService is
     /// @notice whether we are in dev mode or not
     /// if true, verification checks are skipped (only for test deployments)
     /// This flag is set only at initialization and cannot be changed afterwards.
-    bool public immutable devMode;
+    bool public immutable IS_DEV_MODE;
 
     /// The unique identifier (image ID) of the RISC Zero aggregator program.
     /// This ensures that only proofs generated by a trusted Risc0 program can be verified.
@@ -46,8 +46,8 @@ contract AlignedProofAggregationService is
     /// This ensures that only proofs generated by a trusted SP1 program can be verified.
     bytes32 public sp1AggregatorProgramVKHash;
 
-    constructor(bool _devMode) {
-        devMode = _devMode;
+    constructor(bool _isDevMode) {
+        IS_DEV_MODE = _isDevMode;
         _disableInitializers();
     }
 
@@ -76,7 +76,7 @@ contract AlignedProofAggregationService is
         (bytes32 merkleRoot) = abi.decode(sp1PublicValues, (bytes32));
 
         // In dev mode, poofs are mocked, so we skip the verification part
-        if (!devMode) {
+        if (!IS_DEV_MODE) {
             ISP1Verifier(sp1VerifierAddress).verifyProof(sp1AggregatorProgramVKHash, sp1PublicValues, sp1ProofBytes);
         }
 
@@ -91,7 +91,7 @@ contract AlignedProofAggregationService is
         (bytes32 merkleRoot) = abi.decode(risc0JournalBytes, (bytes32));
 
         // In dev mode, poofs are mocked, so we skip the verification part
-        if (!devMode) {
+        if (!IS_DEV_MODE) {
             bytes32 risc0JournalDigest = sha256(risc0JournalBytes);
             IRiscZeroVerifier(risc0VerifierAddress).verify(
                 risc0ReceiptSeal, risc0AggregatorProgramImageId, risc0JournalDigest
diff --git a/network_params.yaml b/network_params.yaml

Original file line number	Diff line number	Diff line change
`@@ -12,5 +12,5 @@`
`12`	`12`	`"permissions": {`
`13`	`13`	`"owner": "0x14dC79964da2C08b23698B3D3cc7Ca32193d9955"`
`14`	`14`	`},`
`15`		`- "devMode": false`
	`15`	`+ "isDevMode": false`
`16`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,5 +11,5 @@`
`11`	`11`	`"permissions": {`
`12`	`12`	`"owner": "0x97aEC5F28181abe5d2aD40dBe7FbaEe014529b7D"`
`13`	`13`	`},`
`14`		`- "devMode": false`
	`14`	`+ "isDevMode": false`
`15`	`15`	`}`