-
Notifications
You must be signed in to change notification settings - Fork 391
feat: add user error metrics #1356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JulianVentura
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it on my machine and worked very well.
I'll leave just some notes:
- If no error happened, the grafana panel shows "No data" and I don't know if there is a problem with the metric or there aren't any errors. Can we initialize the total number with zero so the panel shows right from the start?
- I tried to trigger some other user errors by modifying the provided data to the batcher and spotted a bug which I made an issue of. Maybe you want to address it later.
IMO initializing every value to zero doesn’t seem like a clean approach in the code. Also, it is not that bad to show "no data" until the errors start to appear, it's how Grafana behaves in that case. Anyway, I’m open to changing it if that’s what you think is best!
Nice catch! I agree this should be handled in a separate PR. |
Yes, it's ok, I just wanted to point it in case you didn't notice. We can leave it like that, if that's how Grafana usually behaves in these scenarios. |
MauroToscano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the disabled verifier error dedicated panel, and proving system panel, if the other covers these 2
Done! |
Add User Error Metrics
Warning
This PR requires the deploy of new metrics/dashboards
Description
This PR adds a new panel to our batcher Grafana dashboard.
User Error Count
Tracks the occurrence of the different user errors in the batcher. The error types included are:
InvalidChainIdInvalidSignatureProofTooLargeDisabledVerifierRejectedProofInsufficientBalanceInvalidNonceEthRpcErrorInvalidMaxFeeAddToBatchErrorInvalidReplacementMessageHow to test
Run:
Go to
localhost:3000and you should see the new panel in the batcher dashboard.Then, you can modify the task sender in
batcher/aligned/src/main.rsto trigger the different errors in the batcher. For example, you can modify thechain_idwith an invalid value:Or change the
public_input, to get arejected_prooferror:and run:
Type of change
Checklist
testnet, everything else tostaging