Skip to content

refactor: separate batcher retry constants properly #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
uri-99 merged 8 commits into from
Nov 13, 2024
Merged

refactor: separate batcher retry constants properly #1408

uri-99 merged 8 commits into from
Nov 13, 2024

Conversation

@avilagaston9
Copy link
Contributor

@avilagaston9 avilagaston9 commented Nov 12, 2024 •
edited
Loading

Separate batcher retry constants properly

Warning

This PR should be merged after #1405

Description

Separates batcher retry constants into two:

  • ETHEREUM_CALL: get_gas_price, get_nonce, etc.
  • BUMP: Only used in cancel_create_new_task_tx to bump the cancel tx.

Type of change

  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@avilagaston9 avilagaston9 self-assigned this Nov 12, 2024
@avilagaston9 avilagaston9 added the batcher issues within aligned-batcher label Nov 12, 2024
@avilagaston9 avilagaston9 marked this pull request as ready for review November 12, 2024 22:13
Base automatically changed from adjust-batcher-retries-parameters to staging November 13, 2024 18:28
@uri-99 uri-99 added this pull request to the merge queue Nov 13, 2024
Merged via the queue into staging with commit 5505e82 Nov 13, 2024
3 checks passed
@uri-99 uri-99 deleted the separate-retry-constants branch November 13, 2024 21:20
PatStiles pushed a commit that referenced this pull request Nov 14, 2024
@avilagaston9 @PatStiles
refactor: separate batcher retry constants properly (#1408)
11c5b22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuArce JuArce JuArce approved these changes

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

+2 more reviewers

@uri-99 uri-99 uri-99 approved these changes

@JulianVentura JulianVentura JulianVentura approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@avilagaston9 avilagaston9

Labels

batcher issues within aligned-batcher

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@avilagaston9 @uri-99 @JulianVentura @JuArce @MarcosNicolau