feat(aggregator): Aggregator Retry improvements

[PatStiles]

Retry interface improvements:

closes #1401 #1414 #1391

Description

Description of the pull request changes and motivation.

Type of change

Please delete options that are not relevant.

• Refactor

Checklist

• Linked to Github Issue

[MauroToscano]

DefaultRetryConfig may be confusing. We should use the same names as in the batcher, to split the chain and non chain constants

[MarcosNicolau]

Did the basics tests on macos and everything worked fine. Minor comments with respect to the fallbacks I need to check if the times match.

[PatStiles]

DefaultRetryConfig may be confusing. We should use the same names as in the batcher, to split the chain and non chain constants

The Batcher uses the following naming scheme for the constants:

/// Ethereum calls retry constants
pub const ETHEREUM_CALL_MIN_RETRY_DELAY: u64 = 500; // milliseconds
pub const ETHEREUM_CALL_MAX_RETRIES: usize = 5;
pub const ETHEREUM_CALL_BACKOFF_FACTOR: f32 = 2.0;
pub const ETHEREUM_CALL_MAX_RETRY_DELAY: u64 = 3600; // seconds

/// Ethereum transaction retry constants
pub const BUMP_MIN_RETRY_DELAY: u64 = 500; // milliseconds
pub const BUMP_MAX_RETRIES: usize = 33; // ~ 1 day
pub const BUMP_BACKOFF_FACTOR: f32 = 2.0;
pub const BUMP_MAX_RETRY_DELAY: u64 = 3600; // seconds

Which indicate the parameters for performing an eth call vs eth transaction. In the operator/aggregator we are differentiating between on-chain vs not on-chain. @MauroToscano I'm not sure if there is overlap as the eth tx retry factors into bumping the tx fee. @avilagaston9 would welcome your thoughts.

[MauroToscano]

DefaultRetryConfig may be confusing. We should use the same names as in the batcher, to split the chain and non chain constants

The Batcher uses the following naming scheme for the constants:

/// Ethereum calls retry constants
pub const ETHEREUM_CALL_MIN_RETRY_DELAY: u64 = 500; // milliseconds
pub const ETHEREUM_CALL_MAX_RETRIES: usize = 5;
pub const ETHEREUM_CALL_BACKOFF_FACTOR: f32 = 2.0;
pub const ETHEREUM_CALL_MAX_RETRY_DELAY: u64 = 3600; // seconds

/// Ethereum transaction retry constants
pub const BUMP_MIN_RETRY_DELAY: u64 = 500; // milliseconds
pub const BUMP_MAX_RETRIES: usize = 33; // ~ 1 day
pub const BUMP_BACKOFF_FACTOR: f32 = 2.0;
pub const BUMP_MAX_RETRY_DELAY: u64 = 3600; // seconds

Which indicate the parameters for performing an eth call vs eth transaction. In the operator/aggregator we are differentiating between on-chain vs not on-chain. @MauroToscano I'm not sure if there is overlap as the eth tx retry factors into bumping the tx fee. @avilagaston9 would welcome your thoughts.

We can use ETHEREUM_CALL as name for consistency if we don't have the other ones.

Default is the strangest one, It's not clear what a default is or why we need it

[JulianVentura]

Code looks fine, just a nit comment. I'll test later

[JulianVentura]

Seems to work fine locally, unit tests are passing too.

[MauroToscano]

We will re do this PR in parts