Skip to content

Fix: Remove anvil unit tests #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 4 commits into from
Nov 22, 2024
Merged

Fix: Remove anvil unit tests #1480

MauroToscano merged 4 commits into from
Nov 22, 2024

Conversation

@PatStiles
Copy link
Contributor

@PatStiles PatStiles commented Nov 22, 2024 •
edited
Loading

Remove anvil unit tests

Description

Closes #1478. Removes anvil unit tests that can break the CI.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@MauroToscano MauroToscano added this pull request to the merge queue Nov 22, 2024
@MauroToscano MauroToscano removed this pull request from the merge queue due to a manual request Nov 22, 2024
MauroToscano
MauroToscano requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@MauroToscano MauroToscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test of the retry isn't using anvil, we should keep it

@PatStiles PatStiles force-pushed the fix/remove-anvil-unit-tests branch from ba31530 to bbdab53 Compare November 22, 2024 18:01
@MauroToscano MauroToscano added this pull request to the merge queue Nov 22, 2024
Merged via the queue into staging with commit 6887704 Nov 22, 2024
5 checks passed
@MauroToscano MauroToscano deleted the fix/remove-anvil-unit-tests branch November 22, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@JuArce JuArce JuArce approved these changes

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

+3 more reviewers

@Oppen Oppen Oppen approved these changes

@uri-99 uri-99 uri-99 approved these changes

@avilagaston9 avilagaston9 avilagaston9 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@PatStiles @Oppen @MauroToscano @uri-99 @JuArce @avilagaston9 @MarcosNicolau