Skip to content

fix: adjust batcher transaction_wait_timeout #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 6 commits into from
Nov 26, 2024
Merged

fix: adjust batcher transaction_wait_timeout #1481

MauroToscano merged 6 commits into from
Nov 26, 2024

Conversation

@avilagaston9
Copy link
Contributor

@avilagaston9 avilagaston9 commented Nov 22, 2024

Adjust Batcher transaction_wait_timeout

Description

Changes the default transaction_wait_timeout in the Batcher to 6 blocks (72 seconds), since we were waiting too short.

Type of change

  • Bug fix

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@avilagaston9 avilagaston9 marked this pull request as ready for review November 22, 2024 16:28
@avilagaston9 avilagaston9 self-assigned this Nov 22, 2024
MauroToscano
MauroToscano reviewed Nov 26, 2024
View reviewed changes
@MauroToscano MauroToscano added this pull request to the merge queue Nov 26, 2024
Merged via the queue into staging with commit 84fadd2 Nov 26, 2024
3 checks passed
@MauroToscano MauroToscano deleted the batcher-transaction-wait-timeout branch November 26, 2024 22:10
PatStiles pushed a commit that referenced this pull request Nov 27, 2024
@avilagaston9 @MauroToscano @PatStiles
fix: adjust batcher transaction_wait_timeout (#1481)
59ca78e 
Co-authored-by: Mauro Toscano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano left review comments

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

+2 more reviewers

@PatStiles PatStiles PatStiles approved these changes

@uri-99 uri-99 uri-99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@avilagaston9 avilagaston9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@avilagaston9 @MauroToscano @PatStiles @uri-99 @MarcosNicolau