Skip to content

fix: task sender nonce #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 1 commit into from
Nov 27, 2024
Merged

fix: task sender nonce #1496

MauroToscano merged 1 commit into from
Nov 27, 2024

Conversation

@MarcosNicolau
Copy link
Member

@MarcosNicolau MarcosNicolau commented Nov 26, 2024 •
edited
Loading

Description

Fixes the task sender nonce by fetching it from the batcher instead of ethereum and calculating it manually.

Type of change

  • Bug fix

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@MauroToscano MauroToscano added this pull request to the merge queue Nov 27, 2024
Merged via the queue into staging with commit f6c5d52 Nov 27, 2024
3 checks passed
@MauroToscano MauroToscano deleted the fix/task-sender-nonce branch November 27, 2024 14:30
avilagaston9 pushed a commit that referenced this pull request Nov 29, 2024
@MarcosNicolau @avilagaston9
fix: task sender nonce (#1496)
74eb005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@JuArce JuArce JuArce approved these changes

+1 more reviewer

@PatStiles PatStiles PatStiles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MarcosNicolau @MauroToscano @PatStiles @JuArce