fix(sdk): Remove max_fee function from sdk #1558
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosNicolau
approved these changes
Dec 3, 2024
Contributor
|
How shall we test it? |
uri-99
reviewed
Dec 3, 2024
| pub async fn fee_per_proof( | ||
| pub async fn max_fee_per_proof( | ||
| eth_rpc_url: &str, | ||
| num_proofs_per_batch: usize, |
Contributor
There was a problem hiding this comment.
change to num_proofs_in_batch
uri-99
reviewed
Dec 3, 2024
| /// * `EthereumProviderError` if there is an error in the connection with the RPC provider. | ||
| /// * `EthereumGasPriceError` if there is an error retrieving the Ethereum gas price. | ||
| pub async fn fee_per_proof( | ||
| pub async fn max_fee_per_proof( |
Contributor
There was a problem hiding this comment.
change to suggest_fee_per_proof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes max_fee function from sdk
Description
Removes a
max_feefunction that computed the total fee for a user submitting a batch ofnproof into a batch of sizenum_proofs_in_batch.fee_per_proofis renamed tomax_fee_per_proof. Open to renaming suggestions.Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging