hotfix(aggregator): nil dereference for invalid signature #1753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An operator could trigger a
nil-dereference in the aggregator and bring it down by sending a message with anil-signature.Catch this error, log a warning and return an error instead.
The log is level warning to avoid polluting with unnecessary stack traces.
Fixes #1747
Type of change
Checklist
testnet, everything else tostagingTesting
Apply the following patch:
Then start sending proofs, the aggregator should log an error an keep going. In testnet this should crash the aggregator.