refactor(aggregation_mode): migrate merkle tree to lambdaworks #1911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauroToscano
reviewed
May 6, 2025
Comment on lines
65
to
67
| fn hash_leaves(leaves: &[Self::Data]) -> Vec<Self::Node> { | ||
| leaves.iter().map(|l| l.0).collect() | ||
| } |
Contributor
There was a problem hiding this comment.
This a bit orthodox, hash_leaves doesn't need to be redefined, but if you need it, then it should use hash_data, else hash_data has no purpose. We can re check it tomorrow
Suggested change
| fn hash_leaves(leaves: &[Self::Data]) -> Vec<Self::Node> { | |
| leaves.iter().map(|l| l.0).collect() | |
| } | |
| fn hash_leaves(leaves: &[Self::Data]) -> Vec<Self::Node> { | |
| leaves.iter().map(|l| l.0).collect() | |
| } |
Member
Author
MauroToscano
requested changes
May 6, 2025
Contributor
MauroToscano
left a comment
MauroToscano
left a comment
There was a problem hiding this comment.
We need to re review the backend definition
JuArce
changed the title
MauroToscano
approved these changes
May 8, 2025
JuArce
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description of the pull request changes and motivation.
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging