-
Notifications
You must be signed in to change notification settings - Fork 391
fix(ethereum_package): fix localnet/devnet on Ethereum package #1937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ethereum_package): fix localnet/devnet on Ethereum package #1937
Conversation
fix: update SDK
fix: mint mock tokens and deposit into strategy fix: whitelist weth strategy in devnet chore: update sdk
…e-contracts-to-new-eigenlayer-version
chore: set consensus layer ports
MarcosNicolau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked for me. I had to change the ports in the ethereum-packageconfigs for the fallback nodes, maybe there is a way to make them deterministic.
I updated the config files. Ports are deterministic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issues with the Ethereum package by updating deployed contracts to the new eigenlayer version and ensuring configuration consistency for localnet/devnet deployments. Key changes include:
- Adding default RPC_URL handling in multiple shell scripts.
- Updating configuration files with new service addresses and fallback endpoints.
- Introducing new Makefile targets to support Ethereum package proof aggregation and operator management.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/user_fund_payment_service_devnet.sh | Added default RPC_URL check and replaced hardcoded RPC URL in cast commands. |
| scripts/mint_mock_token.sh | Added default RPC_URL check and updated cast call with RPC_URL flag. |
| scripts/fund_operator_devnet.sh | Added default RPC_URL check and replaced hardcoded RPC URL in operator fund commands. |
| explorer/.env.dev | Replaced placeholder BEACON_CLIENT with an explicit localhost URL. |
| config-files/config-proof-aggregator-mock.yaml | Updated configuration with aligned and proof aggregation service addresses. |
| config-files/config-proof-aggregator-mock-ethereum-package.yaml | Added new configuration file for mock aggregator in Ethereum package. |
| config-files/config-proof-aggregator-ethereum-package.yaml | Added new configuration file for production proof aggregator in Ethereum package. |
| config-files/config-operator-1-ethereum-package.yaml | Updated RPC and WS fallback endpoints to match the new network configuration. |
| config-files/config-batcher-ethereum-package.yaml | Updated fallback endpoints to reflect newly assigned ports. |
| config-files/config-aggregator-ethereum-package.yaml | Revised fallback endpoints and adjusted garbage collector settings. |
| Makefile | Added new targets for starting proof aggregators and updated operator start commands. |
Comments suppressed due to low confidence (1)
Makefile:1339
- [nitpick] Ensure that setting ENVIRONMENT=devnet for the operator start target is intentional and consistent with your deployment requirements.
$(MAKE) operator_start ENVIRONMENT=devnet OPERATOR_ADDRESS=0x70997970C51812dc3A010C7d01b50e0d17dc79C8 CONFIG_FILE=config-files/config-operator-1-ethereum-package.yaml
Update contracts to new eigenlayer version
Description
This PR updates the deployed contracts in ethreum package.
Note: Anvil and Ethereum Package have the same contracts addresses, so the SDK is fully compatible with both using
Network::devnetCloses #1936
How to Test
Update Kurtosis
Test Aggregation Layer
Set the following values in
explorer/.envNote: If you see errors with docker container, run
make explorer_build_dbhttp://localhost:4000/batchesDo not stop Ethereum Package so you can test the aggregation mode with the proofs already sent
Test Aggregation Mode
Note: aggregated proofs in dev won't be displayed in the explorer
Note: This step takes several minutes
http://localhost:4000/aggregated_proofsThe output must be:
Type of change
Checklist
testnet, everything else tostaging