-
Notifications
You must be signed in to change notification settings - Fork 391
feat/perf(aggregation-mode): verification & sp1 aggregation #1955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuArce
reviewed
May 30, 2025
Co-authored-by: Julian Arce <[email protected]>
JuArce
approved these changes
May 30, 2025
Co-authored-by: Mauro Toscano <[email protected]>
MauroToscano
requested changes
Jun 3, 2025
Contributor
MauroToscano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the flag, and always pre verify, it has no cost and may avoid issues
MauroToscano
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While aggregating many proofs in sp1 we noticed that setting up the prover has quite the overhead (around
400ms). This pr addresses that issue by:elfevery time: for this the proof pre verification was moved to the creation of the struct so that the vk is computed only once and in parallel regarded if the pre-verification is enabled or not.Other minor things have been added:
Results
With a 3090 the following results were observed:
The verification in the fetching process for a batch of 40 proofs takes:
Aggregation of 150 proofs in chunks of 128 took:
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging