-
Notifications
You must be signed in to change notification settings - Fork 391
fix(batcher): non paying proofs are ignored when queue is full #1958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JuArce
merged 19 commits into
staging
from
1957-fix-non-paying-proofs-are-ignored-when-queue-is-full
Jun 3, 2025
Merged
fix(batcher): non paying proofs are ignored when queue is full #1958
JuArce
merged 19 commits into
staging
from
1957-fix-non-paying-proofs-are-ignored-when-queue-is-full
Jun 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosNicolau
approved these changes
Jun 2, 2025
MauroToscano
approved these changes
Jun 2, 2025
MauroToscano
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non paying proofs are ignored when queue is full
Description
When the queue is full, non-paying proofs were being ignored
This PR fixes that by performing replacement on low-fee proofs
How to Test
Set
max_queue_size: 10inconfig-batcher-ethereum-package.yamlRun batcher
anvil_7's proofs should be replaced with non-paying proofs and the the batch should be created
Type of change
Checklist
testnet, everything else tostaging