Skip to content

Conversation

@MarcosNicolau
Copy link
Member

Description

Uploads benchmark results for the aggregation mode.

Type of change

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@MarcosNicolau MarcosNicolau self-assigned this Jun 5, 2025
@JuArce JuArce changed the title docs(agg-mode): upload benchmarks docs(aggregation_mode): upload benchmarks Jun 5, 2025
@MarcosNicolau
Copy link
Member Author

@JuArce Your comments have been solved in ef65085.

Copy link
Contributor

@MauroToscano MauroToscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most important number, time per proof, is missing

@MarcosNicolau
Copy link
Member Author

MarcosNicolau commented Jun 11, 2025

The most important number, time per proof, is missing

Thanks for pointing that out, it's now included in 8e0137c. I initially left it out because I wasn't sure it would be meaningful in isolation as the time per proof isn’t constant and depends on the number of proofs. That said, now that I think about it, I do agree it’s a useful point of reference, especially when comparing different setups under similar aggregation volumes and observing the amortization as we increase the batch size.

@MarcosNicolau
Copy link
Member Author

MarcosNicolau commented Jun 26, 2025

Closing it as we'll only keep it as reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants