Fix: name for reasoning_context for openai provider#2940
Fix: name for reasoning_context for openai provider#2940jaljoue wants to merge 6 commits intoyetone:mainfrom
Conversation
|
after apply this, kimi keep reporting reasoning_content is missing in assistant tool call message at index 6 |
Interesting, I will keep testing. @CodingPapi curious did you test with Openrouter or with Moonshot directly? |
nope, only try this with Avante |
Hi, have you reproduce this? is it a better solution that we create a specific provider only for kimi? |
|
this is related info: anomalyco/opencode#4947 |
|
Tried this PR with Deepseek's API in a new Ask, but got this error almost immediately: |
@INFCode When you have a chance could you try again with the latest changes? I had some other changes in a different branch that was a more complex change but might also fix it. |
With the new changes, this time the ask session runs slightly longer, but there's still some problem. This time Deepseek shows a short thought and executes a Bash command successfully, but then it throws the same error. |
|
@INFCode @CodingPapi Think it should be working now, I tested with Deepseek API as well, i'll try with some others to double check. |
I was testing out Kimi K2.5 through OpenRouter which inherits from the OpenAI provider, and noticed that there was missing reasoning_context after requests. Tracked it down to the add_thinking_messages function, was a simple typo.
This may also close #2851 , but I would need someone to test that I don't have Deepseek setup as a provider.