-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Introduce explicit internal datastructures modeling dom state #2330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 24 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
5f6e8ed
detach destructures now
WorldSEnder b302a88
add failing keyed-list issue
WorldSEnder 994a6db
crude port to the new bundle infrastructure
WorldSEnder 38fb925
port over the infrastructure
WorldSEnder 355e328
mass rename: apply -> reconcile
WorldSEnder 35d7c2e
get rid of move_before in favor of shift
WorldSEnder d9bd30a
generate id directly when creating a new scope
WorldSEnder c843a2b
bundle for text nodes
WorldSEnder f576c36
work on naming: ancestor -> bundle
WorldSEnder 751fed2
slightly optimize list reconciler, add doccomments
WorldSEnder 749c078
address review
WorldSEnder cac9066
Merge remote-tracking branch 'upstream/master' into dom-bundle
WorldSEnder c357045
add internal documentation
WorldSEnder a95bf13
address review comments
WorldSEnder 3563f39
move even more stuff into dom_bundle to scope exports
WorldSEnder c1a0b49
move replace into Reconcilable
WorldSEnder 0ae4063
Merge remote-tracking branch 'upstream/master' into dom-bundle
WorldSEnder 25a760c
move lifecycle and scope back into html as per review
WorldSEnder 8704881
move back Value and InputFields into html
WorldSEnder 02800d3
actually only type-check format args in production
WorldSEnder f28ebfe
fix documentation link
WorldSEnder a2a6b92
move btag_impl up into containing module
WorldSEnder 1b446a6
shift comps immediately
WorldSEnder 5339f49
Merge remote-tracking branch 'upstream/master' into dom-bundle
WorldSEnder e96bcec
use list-bundle in tag-bundle
WorldSEnder 3dbc932
fix cargo make tests
WorldSEnder 9ee4561
improve 05_swap benchmark
WorldSEnder b0a16e0
Merge remote-tracking branch 'upstream/master' into dom-bundle
WorldSEnder eca11f4
Merge remote-tracking branch 'upstream/master' into dom-bundle
WorldSEnder 06e736b
Merge remote-tracking branch 'upstream/master' into dom-bundle
WorldSEnder c713027
fix a blunder where I swapped operands
WorldSEnder 5010f34
Merge remote-tracking branch 'upstream/master' into dom-bundle
WorldSEnder 02c7dd6
Merge remote-tracking branch 'upstream/master' into dom-bundle
WorldSEnder c1a7ba9
Merge branch 'master' into dom-bundle
WorldSEnder 0678829
Merge remote-tracking branch 'upstream/master' into dom-bundle
WorldSEnder bea0708
fix naming of BNode variants
WorldSEnder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this module related to
dom_bundle?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dom_bundlecontains state to keep when mounting to the DOM. I think it's just natural that theAppHandleis here, since it contains the state for a whole app - concretely the parent scope.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with keeping it here. If we support any platform other than web, then it'll have to but that's for the future.