#[cfg(feature = "render")] and yew::Renderer
#2498
Conversation
|
Visit the preview URL for this PR (updated for commit a3efdb2): https://yew-rs--pr2498-feat-render-lo1tccs5.web.app (expires Sat, 26 Mar 2022 00:32:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
# Conflicts: # examples/function_router/Cargo.toml # examples/function_router/index.html # examples/function_router/src/main.rs # packages/yew/Cargo.toml
# Conflicts: # packages/yew/src/app_handle.rs # packages/yew/src/dom_bundle/bcomp.rs # packages/yew/src/html/component/scope.rs # packages/yew/src/lib.rs # packages/yew/src/virtual_dom/vcomp.rs
|
Just requesting my own review so I don't forget to look at this |
ranile
left a comment
ranile
left a comment
There was a problem hiding this comment.
Implementation looks good. Just a few comments
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Size Comparison
|
|
The measured drop in size for |
|
function_router has feature render disabled by default because it's also used in ssr by the upcoming ssr_router example. |
|
I suspected as much. Then this is a perfect example of the benefit of having |
|
I will merge this pull request as I believe all items has been addressed. |
4 participants
Description
Originally part of #2453.
yew::Rendererthat supersedesstart_app_*.renderallowing client-side rendering logic to be disabled for server-side rendering.This pull request also includes changes from the following pull requests to avoid repeatedly resolving conflicts:
Caveats
This pull request inevitably introduces a lot of feature flags into the codebase.
However, I don't have a better way to handle this at the moment.
Checklist
cargo make pr-flow