Skip to content

Fix top-level reconciliation in portals #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WorldSEnder merged 1 commit into from
Dec 10, 2022
Merged

Fix top-level reconciliation in portals #3020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions packages/yew/src/dom_bundle/bportal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ impl Reconcilable for VPortal {
self,
_root: &BSubtree,
parent_scope: &AnyScope,
parent: &Element,
_parent: &Element,
next_sibling: NodeRef,
portal: &mut Self::Bundle,
) -> NodeRef {
Expand All @@ -110,8 +110,8 @@ impl Reconcilable for VPortal {
node.reconcile_node(
&portal.inner_root,
parent_scope,
parent,
next_sibling.clone(),
&portal.host,
portal.inner_sibling.clone(),
&mut portal.node,
);
next_sibling
Expand Down Expand Up @@ -181,6 +181,21 @@ mod layout_tests {
},
expected: "<div><i></i><o>PORTAL</o>AFTER</div>",
});
layouts.push(TestLayout {
name: "Portal - update inner content",
node: html! {
<div>
{VNode::VRef(first_target.clone().into())}
{VNode::VRef(second_target.clone().into())}
{VNode::VPortal(VPortal::new(
html! { <> {"PORTAL"} <b /> </> },
second_target.clone(),
))}
{"AFTER"}
</div>
},
expected: "<div><i></i><o>PORTAL<b></b></o>AFTER</div>",
});
layouts.push(TestLayout {
name: "Portal - replaced by text",
node: html! {
Expand Down