Fix autocompletion in html macro for rust-analyzer#3829
Merged
Madoshakalaka merged 1 commit intoyewstack:masterfrom Mar 25, 2025
Merged
Conversation
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
|
Visit the preview URL for this PR (updated for commit b4185b5): https://yew-rs-api--pr3829-improve-html-macro-r-kd57veoz.web.app (expires Sun, 30 Mar 2025 12:31:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Member
|
@its-the-shrimp does this make sense? |
Contributor
Sure does, parsing Rust code for no apparent reason doesn't make too much sense, both from a performance & a DX standpoint, so this is a great change |
Madoshakalaka
approved these changes
Mar 25, 2025
Member
Madoshakalaka
left a comment
Madoshakalaka
left a comment
There was a problem hiding this comment.
LGTS, thanks for contributing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In rust-analyzer it was not possible to get autocompletion suggestions inside of expression in the
html!macro. This change should fix that. The first part is removing usage of thevec!macro as that seemed to hinder autocompletion and the second part is allowing to parse invalid expressions so rust-analyzer gets some output from the macro.Checklist