yew: function_component -> component#3885
Merged
Madoshakalaka merged 3 commits intoyewstack:masterfrom Jul 21, 2025
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit bde1747): https://yew-rs--pr3885-function-component2c-4s095iys.web.app (expires Sun, 27 Jul 2025 21:23:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - coreYew MasterPull Request |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
Madoshakalaka
approved these changes
Jul 21, 2025
Member
Madoshakalaka
left a comment
There was a problem hiding this comment.
nice touch with the deprecated attribute. I had thought it was functional_component for the longest time, less words are better 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #3447
#[function_component]is too verbose, there's no reason to specify that it's a function, if the attribute is attached to a function, thus I propose renaming it to#[component]Not adjusting the examples until the release of v0.22, so that example continue to represent Yew as it is for external users
Checklist