Skip to content

Remove manual allow(clippy::incompatible_msrv) attribute#3889

Merged
WorldSEnder merged 1 commit intomasterfrom
remove-incompatible-msrv-lint
Aug 10, 2025
Merged

Remove manual allow(clippy::incompatible_msrv) attribute#3889
WorldSEnder merged 1 commit intomasterfrom
remove-incompatible-msrv-lint

Conversation

@Madoshakalaka
Copy link
Member

@Madoshakalaka Madoshakalaka commented Aug 9, 2025

rustversion 1.0.22 now turns off incompatible_msrv automatically

@Madoshakalaka Madoshakalaka marked this pull request as ready for review August 9, 2025 05:43
github-actions[bot]
github-actions bot previously approved these changes Aug 9, 2025
@github-actions
Copy link

github-actions bot commented Aug 9, 2025

Visit the preview URL for this PR (updated for commit 6342b1b):

https://yew-rs-api--pr3889-remove-incompatible-ir78rc1f.web.app

(expires Sat, 16 Aug 2025 22:17:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Aug 9, 2025

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 310.580 311.951 310.978 0.440
Hello World 10 472.887 487.205 477.000 4.784
Function Router 10 1590.489 1613.208 1599.230 7.529
Concurrent Task 10 1005.334 1007.556 1006.711 0.644
Many Providers 10 1021.294 1047.944 1033.963 10.581

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 290.894 291.772 291.073 0.257
Hello World 10 473.563 501.400 485.013 7.271
Function Router 10 1584.923 1630.919 1609.827 11.201
Concurrent Task 10 1005.076 1007.770 1006.558 0.747
Many Providers 10 1097.347 1131.463 1118.179 9.627

@github-actions
Copy link

github-actions bot commented Aug 9, 2025

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 99.420 99.420 0 0.000%
boids 168.206 168.205 -0.001 -0.001%
communication_child_to_parent 91.779 91.776 -0.003 -0.003%
communication_grandchild_with_grandparent 102.802 102.801 -0.001 -0.001%
communication_grandparent_to_grandchild 97.797 97.801 +0.004 +0.004%
communication_parent_to_child 87.693 87.694 +0.001 +0.001%
contexts 103.909 103.901 -0.008 -0.008%
counter 84.495 84.495 0 0.000%
counter_functional 84.849 84.851 +0.002 +0.002%
dyn_create_destroy_apps 87.431 87.433 +0.002 +0.002%
file_upload 98.551 98.549 -0.002 -0.002%
function_memory_game 169.769 169.771 +0.003 +0.002%
function_router 336.927 336.811 -0.116 -0.034%
function_todomvc 162.885 162.887 +0.002 +0.001%
futures 235.953 235.953 0 0.000%
game_of_life 104.456 104.456 0 0.000%
immutable 194.151 194.111 -0.040 -0.021%
inner_html 80.152 80.152 0 0.000%
js_callback 107.566 107.562 -0.004 -0.004%
keyed_list 195.417 195.416 -0.001 -0.000%
mount_point 83.513 83.513 0 0.000%
nested_list 112.625 112.627 +0.002 +0.002%
node_refs 90.874 90.871 -0.003 -0.003%
password_strength 1782.872 1782.873 +0.001 +0.000%
portals 92.659 92.658 -0.001 -0.001%
router 306.391 306.276 -0.114 -0.037%
suspense 111.578 111.658 +0.080 +0.072%
timer 88.664 88.664 0 0.000%
timer_functional 94.690 94.689 -0.001 -0.001%
todomvc 143.130 143.130 0 0.000%
two_apps 85.872 85.872 0 0.000%
web_worker_fib 134.950 134.948 -0.002 -0.001%
web_worker_prime 185.105 185.111 +0.006 +0.003%
webgl 83.009 83.009 0 0.000%

✅ None of the examples has changed their size significantly.

@Madoshakalaka Madoshakalaka force-pushed the remove-incompatible-msrv-lint branch from 62f9af2 to c3f7e1e Compare August 9, 2025 05:55
@Madoshakalaka Madoshakalaka marked this pull request as draft August 9, 2025 07:13
@Madoshakalaka Madoshakalaka force-pushed the remove-incompatible-msrv-lint branch 2 times, most recently from 23affe7 to b63e219 Compare August 9, 2025 20:10
@Madoshakalaka Madoshakalaka marked this pull request as ready for review August 9, 2025 20:34
github-actions[bot]
github-actions bot previously approved these changes Aug 9, 2025
@Madoshakalaka Madoshakalaka changed the title Remove incompatible msrv lint Remove manual allow(incompatible_msrv) attribute Aug 9, 2025
@Madoshakalaka Madoshakalaka changed the title Remove manual allow(incompatible_msrv) attribute Remove manual allow(clippy::incompatible_msrv) attribute Aug 9, 2025
Copy link
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really quick fix on the side of rustversion, nice.

.gitignore Outdated
*.iml
/.idea/
/.vscode/
CLAUDE.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider ignoring that locally

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually wanted to do that but had no clue how to until I just learned about .git/info/exclude , thanks!

@WorldSEnder WorldSEnder merged commit 4ca16f9 into master Aug 10, 2025
24 checks passed
@WorldSEnder WorldSEnder deleted the remove-incompatible-msrv-lint branch October 22, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants