Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions .github/workflows/clippy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,31 @@ jobs:
toolchain: stable
components: clippy

- uses: taiki-e/install-action@cargo-hack

- uses: Swatinem/rust-cache@v2
with:
shared-key: clippy

- name: Lint feature soundness
if: matrix.profile == 'dev'
run: bash ./ci/feature-soundness.sh
run: >-
cargo hack clippy
-p yew -p yew-agent -p yew-router
--feature-powerset --no-dev-deps
--exclude-features test,serde,not_browser_env
--keep-going
-- -D warnings

- name: Lint feature soundness
if: matrix.profile == 'release'
run: bash ./ci/feature-soundness-release.sh
run: >-
cargo hack clippy
-p yew -p yew-agent -p yew-router
--feature-powerset --no-dev-deps
--exclude-features test,serde,not_browser_env
--keep-going --release
-- -D warnings

clippy:
name: Clippy Workspace
Expand Down
2 changes: 1 addition & 1 deletion Makefile.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
# * doc-test
# * website-test
#
# packages/yew also contains `clippy-feature-soundness` to ensure everything is fine
# packages/yew also contains `clippy-feature-soundness` (requires cargo-hack)
# Run `cargo make --list-all-steps` for more details.
#
######################
Expand Down
20 changes: 0 additions & 20 deletions ci/feature-soundness-release.sh

This file was deleted.

20 changes: 0 additions & 20 deletions ci/feature-soundness.sh

This file was deleted.

15 changes: 9 additions & 6 deletions packages/yew/Makefile.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,12 @@ args = ["test", "--all-targets", "--all-features"]
dependencies = ["native-test", "wasm-test"]

[tasks.clippy-feature-soundness]
script = '''
#!/usr/bin/env bash
set -ex
bash ../../ci/feature-soundness.sh
bash ../../ci/feature-soundness-release.sh
'''
command = "cargo"
args = [
"hack", "clippy",
"-p", "yew", "-p", "yew-agent", "-p", "yew-router",
"--feature-powerset", "--no-dev-deps",
"--exclude-features", "test,serde,not_browser_env",
"--keep-going",
"--", "-D", "warnings",
]
Loading