fix: allow bare None for Option props in html! macro#4021
Open
Madoshakalaka wants to merge 1 commit intomasterfrom
Open
fix: allow bare None for Option props in html! macro#4021Madoshakalaka wants to merge 1 commit intomasterfrom
Madoshakalaka wants to merge 1 commit intomasterfrom
Conversation
The html! macro now detects bare `None` and bypasses IntoPropValue, avoiding type inference ambiguity when multiple Option<X> -> Option<Y> impls exist. Fixes #3747.
|
Visit the preview URL for this PR (updated for commit 81efe92): https://yew-rs-api--pr4021-fix-none-value-senti-m40zxj84.web.app (expires Sat, 07 Mar 2026 22:36:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - coreYew MasterPull Request |
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3747
Unblocks #4020
Propertiesderive: for props whose type isOption<_>, generates an additional{name}_none()setter that assignsSome(None)directly, bypassingIntoPropValuehtml!macro: detects when a prop value is literallyNoneand routes to the_nonesetter instead of the normal oneThis means
Nonenever goes through trait resolution, so it works regardless of how manyIntoPropValue<Option<T>>impls exist.Caveat
If a user passes
Noneto a non-Optionprop (e.g.foo: Stringwithfoo={None}), the error changes from a type inference failure tono method named foo_none found. It might be a bit cryptic to the user but both are compile errors pointing to the correct line, only the message text differs. I think this is acceptible as it is an uncommon mistake.checklist