Fix #1798 for CMake #1944
Merged
Fix #1798 for CMake #1944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jimmy-park @sum01 this is my first modification in test/CMakeLists.txt. :) |
sum01
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Pretty good.
There's a small gotcha with the OPENSSL_VERSION potentially not matching the bin file you find with find_program, but that's at most an edge-case for people with multiple OpenSSL installed with the same bin names that also share locations. So basically no one I guess?
Technically you could pull the version from the bin directly by using openssl version and running some REGEX on its output.
Anyways, LGMT & passed on my machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.