Refine when content is expected #2044
Conversation
|
@falbrechtskirchinger thanks for the pull request, but #609 appears again with this change. Could you take a look at it? |
Sure, I'll take a look.
Thanks! |
Consider Content-Length and Transfer-Encoding headers when determining whether to expect content. Don't handle the HTTP/2 connection preface pseudo-method PRI. Fixes yhirose#2028.
falbrechtskirchinger
force-pushed
the
fix2028
branch
from
ecc1628 to
5733afa
Compare
|
@yhirose I've re-added |
| inline bool expect_content(const Request &req) { | ||
| if (req.method == "POST" || req.method == "PUT" || req.method == "PATCH" || | ||
| req.method == "PRI" || req.method == "DELETE") { | ||
| req.method == "DELETE") { |
There was a problem hiding this comment.
Nice, thanks for the fix. Btw as explained in #2028 (comment) , we should also add OPTIONS here (or maybe replace HEAD with OPTIONS here, I'm not sure if the browser even use HEAD or not)
There was a problem hiding this comment.
No problem. As long as Content-Length is set, things should work. The explicit handling of DELETE is specifically for handlers with content receivers. For OPTIONS requests, we have no such handlers.
I cannot reproduce any issues with OPTIONS. If that still fails, let me know what you're doing and I'll check on my end.
|
@falbrechtskirchinger thanks for the fine contribution! |
3 participants
Consider
Content-LengthandTransfer-Encodingheaders when determining whether to expect content.Don't expect content fordon't handle the HTTP/2 connection preface pseudo-methodDELETErequests andPRI.Fixes #2028.