ci: add abidiff workflow #2054
ci: add abidiff workflow #2054
Conversation
|
Note: I'm not sure this works correctly on pull requests, since they may contain more than one commit. |
Tachi107
force-pushed
the
abidiff
branch
2 times, most recently
from
ac1fa26 to
8d46cc6
Compare
.github/workflows/abidiff.yaml
Outdated
|
|
||
| - name: Checkout previous | ||
| working-directory: previous | ||
| run: git checkout HEAD^ |
There was a problem hiding this comment.
Could you try git checkout $(git describe --tags --abbrev=0 master)?
$(git describe --tags --abbrev=0 master) gives us the commit hash for the latest version tag.
There was a problem hiding this comment.
You mean diffing the current commit with the previous release? Brilliant! Didn't think about it :)
Thanks a lot for taking care of it! I made a comment about how to get the commit hash for the latest version tag. Could you try with it to see how it goes? |
Tachi107
force-pushed
the
abidiff
branch
4 times, most recently
from
92437fc to
7b972d5
Compare
This CI workflow checks ABI compatibility between the pushed commit and the latest tagged release, helping preventing accidental ABI breaks. Helps with yhirose#2043
Done! The job now fails because it has detected breaking changes since the last tagged release, and abidiff returns a status code of |
|
Thanks for the great work! |
2 participants
This CI workflow checks ABI compatibility between the pushed commit and the previous, helping preventing accidental ABI breaks.
Helps with #2043
Cc: @mgorny