Fix #2217 #2218
Fix #2217 #2218
Conversation
|
@JakubHazik thanks for the pull request. Could you take a look at the GitHub Actions workflow failures and compiler warnings? (You don't need to worry about the |
| void set_ca_cert_path(const std::string &ca_cert_file_path, | ||
| const std::string &ca_cert_dir_path = std::string()); | ||
| void set_ca_cert_store(X509_STORE *ca_cert_store); | ||
| virtual void set_ca_cert_store(X509_STORE *ca_cert_store); |
There was a problem hiding this comment.
Could you please remove virtual. It's not necessary.
| inline void Client::set_ca_cert_store(X509_STORE *ca_cert_store) { | ||
| if (is_ssl_) { | ||
| static_cast<SSLClient &>(*cli_).set_ca_cert_store(ca_cert_store); | ||
| dynamic_cast<SSLClient &>(*cli_).set_ca_cert_store(ca_cert_store); |
There was a problem hiding this comment.
Could you please revert it to static_cast?
| inline long Client::get_openssl_verify_result() const { | ||
| if (is_ssl_) { | ||
| return static_cast<SSLClient &>(*cli_).get_openssl_verify_result(); | ||
| return dynamic_cast<SSLClient &>(*cli_).get_openssl_verify_result(); |
There was a problem hiding this comment.
Could you please revert it to static_cast, too?
|
|
||
| inline SSL_CTX *Client::ssl_context() const { | ||
| if (is_ssl_) { return static_cast<SSLClient &>(*cli_).ssl_context(); } | ||
| if (is_ssl_) { return dynamic_cast<SSLClient &>(*cli_).ssl_context(); } |
There was a problem hiding this comment.
Could you please revert it to static_cast, too?
|
@JakubHazik I made come comments. After the adjustments are made, could you please run clang-format, so that |
|
I made the adjustments for you at eb5a65e. :) |
|
Thank you so much. Sorry for my delay, but I was on vacation :) |
|
No problem. Thanks for your fine contribution! |
2 participants
Try resolve #2217
Transmit X509_STORE between SSLClient-s during redirect.
Make variable
ca_cert_store_reusable between multiple clients