[cmake] FindBrotli: do not add Brotli:: targets if they already exist
#2249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not checking for this is terrible practice.
|
@sum01 @jimmy-park could you please review this change? |
sum01
approved these changes
Oct 16, 2025
|
It's worth noting that this is kind of a band-aid, there's some other weird stuff going on with the FindBrotli call that I looked at but this ended up being the most elegant. If nobody else looks I will take a look later, but the gist of it is that ALIAS targets are evil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not checking for this is terrible practice.