Open
Conversation
noughtmare
reviewed
Jun 14, 2018
yi-misc-modes/src/Yi/Lexer/YAML.x
Outdated
| \n | ||
| { c Style.quoteStyle } | ||
| . | ||
| { c Style.quoteStyle } |
Member
There was a problem hiding this comment.
I think making this defaultStyle is better, quoteStyle is really for Template Haskell or lisp style quotes. See https://github.com/yi-editor/yi/blob/master/yi-misc-modes/src/Yi/Lexer/JSON.x for a comparable lexer.
Contributor
Author
There was a problem hiding this comment.
Thank you for your review in your busy time
I'll fix the style.(I wonder if I should use defaultStyle or other styles.)
junjihashimoto
force-pushed
the
feature/yaml
branch
from
294869f to
a9dc927
Compare
noughtmare
reviewed
Jun 21, 2018
yi-misc-modes/src/Yi/Lexer/YAML.x
Outdated
| { | ||
| ^\%.* { c Style.importStyle } | ||
| ^\-\-\- { c Style.importStyle } | ||
| ^$space*\#.* { c Style.commentStyle } |
Member
There was a problem hiding this comment.
Comments can also appear after some other tokens, like:
# Comment on a line
"symfony 1.0": { PHP: 5.0, Propel: 1.2 } # Comment at the end of a line
"symfony 1.2": { PHP: 5.2, Propel: 1.3 }Taken from: https://symfony.com/doc/current/components/yaml/yaml_format.html#comments
Contributor
Author
There was a problem hiding this comment.
Changed a comment-pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Add the highlight of yaml-file.