Claude/fix zhipu translation saving 01 s hd pa z ej5q7wgbie h zv s qi#480
Closed
wafkaw wants to merge 2 commits intoyihong0618:mainfrom
Closed
Conversation
When using batch translation (translate_list), if some paragraphs fail to translate properly, an empty string is returned. This caused the insert_trans method to: 1. Create a new paragraph with empty translation 2. Remove the original paragraph 3. Result: original text is lost Fix by checking if translation text is empty before inserting. If empty: - In single-translate mode: keep original text, don't remove it - In bilingual mode: don't insert empty translation This particularly affects Zhipu AI translations when content filtering or extraction errors occur.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.