fix: Handle TOC items with uid=None to prevent TypeError when writing EPUB#484
Merged
yihong0618 merged 1 commit intoyihong0618:mainfrom Jan 7, 2026
Merged
Conversation
… EPUB Some EPUB files have TOC (Table of Contents) items where the uid attribute is None. When ebooklib tries to write the NCX file, it passes this None value to lxml's SubElement which expects bytes or unicode, causing a TypeError. This fix adds a _fix_toc_uids() method that recursively processes the TOC and assigns auto-generated uids (navpoint-0, navpoint-1, etc.) to any items that have uid=None. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
|
nice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uidattribute isNoneNonevalue to lxml'sSubElementwhich expects bytes or unicode, causing aTypeError_fix_toc_uids()method that recursively processes the TOC and assigns auto-generated uids (navpoint-0,navpoint-1, etc.) to any items that haveuid=NoneError before fix
Test plan
uid=Nonein TOC items🤖 Generated with Claude Code