fix: update new_p.string when resuming with single_translate#489
Merged
yihong0618 merged 1 commit intoyihong0618:mainfrom Feb 25, 2026
Merged
Conversation
When using --resume with --single_translate, the cached translation was loaded into p.string but new_p.string was still the original text. This caused insert_trans to receive the original text instead of the translation, resulting in English output instead of Chinese.
Owner
|
nice catch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using --resume with --single_translate, the cached translation
was loaded into p.string but new_p.string was still the original text.
This caused insert_trans to receive the original text instead of the
translation, resulting in English output instead of Chinese.
Bug 描述
使用
--resume和--single_translate参数时，输出的仍是英文原文而非中文翻译。根因
_process_paragraph中恢复缓存时只更新了p.string，但insert_trans使用的是new_p.string。修复
在 resume 时也同步更新
new_p.string。