Skip to content

do not rewrite existing slug #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anktx wants to merge 2 commits into
base: master
Choose a base branch
from
Open

do not rewrite existing slug #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec83a14
do not rewrite existing slug
Oct 12, 2013
33b7462
generate unique slug by appending index to existing slug
Oct 12, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 11 additions & 18 deletions SlugBehavior.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,33 +52,25 @@ public function addSlugValidators()
$this,
$this->slugAttribute
));
$list->add(CValidator::createValidator(
'validateUniqueSlug',
$this,
$this->slugAttribute
));
}
}

public function validateExistsSlug()
{
$owner = $this->getOwner();
$title = $owner->getAttribute($this->sourceAttribute);
$slug = $owner->getAttribute($this->slugAttribute);
$i = 1;

if (!empty($title)) {
$owner->setAttribute($this->slugAttribute, $this->generateSlug($title));
}
}
if (!empty($title) && empty($slug))
{
$slug = $this->generateSlug($title);

while ($this->filterBySlug($slug)->count()>0)
$slug = $this->generateSlug($title) . '_' . $i++;

public function validateUniqueSlug()
{
$owner = $this->getOwner();
CValidator::createValidator('unique', $owner, $this->slugAttribute)
->validate($owner, $this->slugAttribute);
// Duplicate errors to source attribute, for show it in forms.
$owner->addErrors(array(
$this->sourceAttribute => $owner->getErrors($this->slugAttribute)
));
$owner->setAttribute($this->slugAttribute, $slug);
}
}

public function findBySlug($slug, $condition = '', array $params = array())
Expand All @@ -93,6 +85,7 @@ public function filterBySlug($slug, $operator = 'AND')
->quoteColumnName($owner->getTableAlias() . '.' . $this->slugAttribute);
$owner->getDbCriteria()
->addCondition($column . ' = :slug', $operator)
->addCondition($owner->tableSchema->primaryKey . ' <> ' . $owner->primaryKey)
->params[':slug'] = $slug;

return $this->getOwner();
Expand Down