Skip to content

Add comments to .env about applicability of the environment variables#453

Merged
samdark merged 2 commits intomasterfrom
docker
Mar 10, 2026
Merged

Add comments to .env about applicability of the environment variables#453
samdark merged 2 commits intomasterfrom
docker

Conversation

@samdark
Copy link
Member

@samdark samdark commented Mar 9, 2026

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copilot AI review requested due to automatic review settings March 9, 2026 21:45
@samdark samdark added the type:docs Documentation label Mar 9, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds clarifying header comments to Docker environment variable files to document where variables are expected to be visible (Compose interpolation vs container/app runtime).

Changes:

  • Add header comments to docker/dev/.env, docker/test/.env, and docker/prod/.env about variables being available in the app/container rather than compose.yml.
  • Add a header comment to docker/.env describing variable applicability.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
docker/test/.env Adds header comment clarifying intended scope of test env vars.
docker/prod/.env Adds header comment clarifying intended scope of prod env vars.
docker/dev/.env Adds header comment clarifying intended scope of dev env vars.
docker/.env Adds header comment about variable scope (currently misleading vs actual Compose behavior).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.96%. Comparing base (71d3a0f) to head (cef41ca).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #453   +/-   ##
=========================================
  Coverage     76.96%   76.96%           
  Complexity       29       29           
=========================================
  Files            11       11           
  Lines           178      178           
=========================================
  Hits            137      137           
  Misses           41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add changelog

@samdark
Copy link
Member Author

samdark commented Mar 10, 2026

@vjik that's pure docs. Nothing in the code changed, nor in user-faced behavior.

@samdark samdark merged commit 0ea8683 into master Mar 10, 2026
19 checks passed
@samdark samdark deleted the docker branch March 10, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:docs Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants