Implement value retrieval and checks by predicate callback

[yus-ham]

closes #135

Q	A
Is bugfix?	❌
New feature?	✔️
Breaks BC?	❌

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (36bf7a5) to head (6135f7f).
Report is 9 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #142   +/-   ##
=========================================
  Coverage     99.76%   99.77%           
- Complexity      214      226   +12     
=========================================
  Files             4        4           
  Lines           429      445   +16     
=========================================
+ Hits            428      444   +16     
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vjik]

Can you fix psalm errors? Seems it shows problems in code...

[yus-ham]

@vjik, @samdark its now now only one is reds. i don't know why it still fails

[vjik]

@vjik, @samdark its now now only one is reds. i don't know why it still fails

It's OK. We have a problem with GitHub action "rector" in forks. It don't work in forks.

[vjik]

Now closure will be inconsistent in getValue() and other methods:

• toArray()
• index()
• getColumn()
• map()

Is there real case for getValue() with closure that implement in current PR?

[yus-ham]

There is a PHP RFC: array_find and its PR that is what actually I need to be implemented.

It seems has been discussed about a month ago and I found exactly it just now.
Now Its OK if this PR would be rejected, or if not, I can continue to push some changes and because this changes has BC and so on. so what if introduce new method instead, maybe find()

Thank you in advance for taking your time.

[vjik]

There is a PHP RFC: array_find and its PR that is what actually I need to be implemented.

It's interesting. May be we keep getValue() as is, but add new methods:

ArrayHelper::find()
ArrayHelper::findKey()
ArrayHelper::any()
ArrayHelper::all()

@samdark @yus-ham What do you think?

[samdark]

Yes makes sense.

[yus-ham]

I'll continue with it

[yus-ham]

done