Skip to content

Conversation

@samdark
Copy link
Member

@samdark samdark commented Sep 13, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues yiisoft/yii-debug#271

@samdark samdark requested review from vjik and xepozz September 13, 2024 09:59
@codecov
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 72 lines in your changes missing coverage. Please review.

Project coverage is 86.95%. Comparing base (1ab3bed) to head (c5eae16).

Files with missing lines Patch % Lines
src/Command/DebugContainerCommand.php 30.76% 72 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##              master     #372       +/-   ##
==============================================
- Coverage     100.00%   86.95%   -13.05%     
- Complexity       164      192       +28     
==============================================
  Files             11       12        +1     
  Lines            448      552      +104     
==============================================
+ Hits             448      480       +32     
- Misses             0       72       +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark
Copy link
Member Author

samdark commented Sep 13, 2024

Avoiding var-dumper dependency is tricky.

@samdark samdark requested review from BoShurik and vjik September 13, 2024 18:50
@vjik vjik added the status:under development Someone is working on a pull request. label Sep 14, 2024
name: 'debug:container',
description: 'Show information about container',
)]
final class DebugContainerCommand extends Command

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to debug tags. Or can I pass tag@tag-name as an id?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please elaborate?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to see all services with given tag. Is it possible now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yiisoft/config must provide API to explore the config files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BoShurik no, it is not possible yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:under development Someone is working on a pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants