Skip to content

Conversation

@samdark
Copy link
Member

@samdark samdark commented May 29, 2025

No description provided.

@samdark samdark requested review from Copilot and vjik May 29, 2025 08:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes punctuation and fixes minor grammar/typos across various Markdown docs.

  • Replaces hyphens in headings with em dashes.
  • Corrects articles, commas, and capitalization for clarity.
  • Harmonizes phrasing in lists and sentences.

Reviewed Changes

Copilot reviewed 74 out of 74 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
019-view-code-style.md Swapped heading hyphen for em dash.
018-widgets.md Added missing article and removed comma splice.
017-tags.md Inserted commas, added articles, and fixed capitalization.
016-security-workflow.md Inserted “a/the,” corrected spacing, and refined lists.
015-phpstorm.md Added “the” before IDE for clarity.
014-docs.md Fixed list punctuation and expanded verb forms.
013-code-review.md Added articles, commas, and improved label sentence.
012-tests.md Refined dash usage and punctuation in guideline.
011-error-correction.md Added “the,” aligned capitalization in sentences.
010-code-style.md Added article, fixed dash, and capitalized title line.
009-design-decisions.md Added commas, “the,” and refined list punctuation.
008-interfaces.md Replaced heading hyphen with em dash.
007-exceptions.md Replaced heading hyphen with em dash.
006-git-commit-messages.md Removed stray hyphens and improved body sentence.
005-development-tool.md Added commas, adjusted tool name spacing, and refined lists.
004-namespaces.md Replaced heading hyphen, reformatted markdown table.
003-roadmap.md Added commas, articles, and refined sentence structure.
002-issue-workflow.md Replaced heading hyphen, added article, and hyphenated phrase.
001-yii-values.md Replaced heading hyphen with em dash.
000-packages.md Replaced heading hyphen with em dash.
Comments suppressed due to low confidence (2)

009-design-decisions.md:4

  • Inconsistent product name formatting: use 'Yii 3' (with a space) instead of 'Yii3' for consistency.
the document, we list important design decisions taken during Yii3 development.

009-design-decisions.md:17

  • Awkward phrasing: rephrase to 'service locator was generally preferred, causing both a dependency on the service locator itself, ...' for clarity.
service locator was generally preferred to cause both a dependency on the service locator itself,

@samdark samdark requested a review from Copilot May 29, 2025 08:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A batch of grammar and typo fixes across the project’s guideline markdown files to improve consistency, punctuation, and clarity.

  • Standardized section headings to use an em dash instead of a hyphen.
  • Added or corrected articles, commas, and capitalization in list items and sentences.
  • Refined awkward phrasing and alignment in markdown tables and bullet lists.

Reviewed Changes

Copilot reviewed 74 out of 74 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
019-view-code-style.md Heading updated to use em dash
018-widgets.md Fixed article usage and punctuation
017-tags.md Added missing comma and refined phrasing
016-security-workflow.md Grammar tweaks in workflow steps
015-phpstorm.md Added missing article in description
014-docs.md Refined tip description and list items
013-code-review.md Fixed comma placement and split sentence
012-tests.md Clarified AAA test structure sentence
011-error-correction.md Grammar fix in class usage sentence
010-code-style.md Adjusted wording in example commentary
009-design-decisions.md Grammar and naming consistency fixes
008-interfaces.md Heading updated to use em dash
007-exceptions.md Heading updated to use em dash
006-git-commit-messages.md Grammar tweak in subject-line rules
005-development-tool.md Grammar tweak and naming consistency
004-namespaces.md Table alignment and delimiter adjustments
003-roadmap.md Grammar tweaks in list items
002-issue-workflow.md Grammar tweak in process description
001-yii-values.md Heading updated to use em dash
000-packages.md Heading updated to use em dash
Comments suppressed due to low confidence (3)

009-design-decisions.md:3

  • Inconsistent naming: use “Yii 3” (with a space) instead of “Yii3” to match other documentation.
In this document, we list important design decisions taken during Yii3 development.

009-design-decisions.md:58

  • Inconsistent naming: use “Yii 3” (with a space) instead of “Yii3” to match other documentation.
In Yii3, we ensured that container can be used to conveniently configure any

005-development-tool.md:3

  • Inconsistent naming: use “Yii 3” (with a space) instead of “Yii3” to match other documentation.
For Yii3, the number of packages increased significantly to achieve more reusability and independent releases.

@samdark samdark requested a review from Copilot May 29, 2025 09:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes minor grammar and typo issues across multiple documentation markdown files. Key changes include standardizing header punctuation, refining sentence structure, and correcting minor wording inconsistencies.

  • Consistent use of em dashes in header titles
  • Improved grammar and refined punctuation in various sections
  • Minor text adjustments to ensure clarity and consistency

Reviewed Changes

Copilot reviewed 74 out of 74 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
019-view-code-style.md Updated header punctuation for consistency
018-widgets.md Minor grammatical corrections
017-tags.md Improved punctuation and sentence structure
016-security-workflow.md Refined wording for clarity
015-phpstorm.md Minor grammar fixes in sentence
014-docs.md Updated phrasing for clarity and consistency
013-code-review.md Polished text and punctuation
012-tests.md Refined phrasing and punctuation
011-error-correction.md Corrected grammatical structure
010-code-style.md Improved sentence clarity
009-design-decisions.md Updated punctuation and wording; slight inconsistency in version label
008-interfaces.md Updated header punctuation
007-exceptions.md Updated header punctuation
006-git-commit-messages.md Refined wording and punctuation
005-development-tool.md Minor text improvements and punctuation adjustments
004-namespaces.md Updated table formatting
003-roadmap.md Improved grammar and added missing commas
002-issue-workflow.md Refined phrasing for clarity
001-yii-values.md Updated header punctuation
000-packages.md Updated header punctuation

@samdark samdark merged commit cf80cfc into master May 29, 2025
2 of 5 checks passed
@samdark samdark deleted the grammar branch May 29, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants