Skip to content

Conversation

@vistart
Copy link
Contributor

@vistart vistart commented Aug 6, 2015

Fix the escape bug.
See detail in #22

Fix the escape bug.
See detail in #22
@samdark samdark assigned samdark and cebe and unassigned samdark Aug 6, 2015
@samdark samdark added the type:bug Bug label Aug 6, 2015
@vistart
Copy link
Contributor Author

vistart commented Aug 25, 2015

Why were these translations merged into #27 ?

@vistart vistart changed the title Fix the escape bug. Fix the escape bug. Add translationsto Guide. Aug 25, 2015
@vistart vistart changed the title Fix the escape bug. Add translationsto Guide. Fix the escape bug. Add translations to Guide. Aug 25, 2015
@cebe
Copy link
Member

cebe commented Aug 25, 2015

because you are working on the master branch. for sending different changes in different PRs you should create different branches.

@vistart
Copy link
Contributor Author

vistart commented Aug 25, 2015

I see. What should I do next? Revert to 7b40fb5? Then create new branch named as "Translation in Simplified Chinese"?

@cebe cebe added this to the 2.0.5 milestone Aug 25, 2015
@cebe
Copy link
Member

cebe commented Aug 25, 2015

No need for that, I can do that myself when merging.

@vistart
Copy link
Contributor Author

vistart commented Aug 25, 2015

OK.

@vistart vistart changed the title Fix the escape bug. Add translations to Guide. Fix the escape bug. Aug 25, 2015
Add translations of Simplified Chinese.
@cebe cebe closed this in d37c989 Mar 1, 2016
@cebe
Copy link
Member

cebe commented Mar 1, 2016

merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants