remove custom added "<?php\n" for php 8.3#20344
Open
mixxael wants to merge 1 commit intoyiisoft:masterfrom
Open
remove custom added "<?php\n" for php 8.3#20344mixxael wants to merge 1 commit intoyiisoft:masterfrom
mixxael wants to merge 1 commit intoyiisoft:masterfrom
Conversation
mixxael
commented
Mar 21, 2025
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20344 +/- ##
=========================================
Coverage 64.85% 64.85%
Complexity 11437 11437
=========================================
Files 431 431
Lines 37199 37199
=========================================
Hits 24125 24125
Misses 13074 13074 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Looks valid |
xepozz
approved these changes
Mar 23, 2025
Member
|
@mixxael could you also add a test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
