chore(deps): update module go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.44.0 [security] (main)

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp	v0.32.0 -> v0.44.0

---

Memory exhaustion in go.opentelemetry.io/contrib/instrumentation

CGA-h2vq-f2rf-jwrq / CVE-2023-45142 / GHSA-rcjv-mgp8-qvmr / GO-2023-2113

More information

Details

Memory exhaustion in go.opentelemetry.io/contrib/instrumentation

Severity

Unknown

References

• https://github.com/open-telemetry/opentelemetry-go-contrib/security/advisories/GHSA-rcjv-mgp8-qvmr
• https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277

This data is provided by OSV and the Go Vulnerability Database (CC-BY 4.0).

---

OpenTelemetry-Go Contrib vulnerable to denial of service in otelhttp due to unbound cardinality metrics

CGA-h2vq-f2rf-jwrq / CVE-2023-45142 / GHSA-rcjv-mgp8-qvmr / GO-2023-2113

More information

Details

Summary

This handler wrapper https://github.com/open-telemetry/opentelemetry-go-contrib/blob/5f7e6ad5a49b45df45f61a1deb29d7f1158032df/instrumentation/net/http/otelhttp/handler.go#L63-L65
out of the box adds labels

• http.user_agent
• http.method

that have unbound cardinality. It leads to the server's potential memory exhaustion when many malicious requests are sent to it.

Details

HTTP header User-Agent or HTTP method for requests can be easily set by an attacker to be random and long. The library internally uses httpconv.ServerRequest that records every value for HTTP method and User-Agent.

PoC

Send many requests with long randomly generated HTTP methods or/and User agents (e.g. a million) and observe how memory consumption increases during it.

Impact

In order to be affected, the program has to configure a metrics pipeline, use otelhttp.NewHandler wrapper, and does not filter any unknown HTTP methods or User agents on the level of CDN, LB, previous middleware, etc.

Others

It is similar to already reported vulnerabilities

• GHSA-5r5m-65gx-7vrh (open-telemetry/opentelemetry-go-contrib)
• GHSA-cg3q-j54f-5p7p (prometheus/client_golang)

Workaround for affected versions

As a workaround to stop being affected otelhttp.WithFilter() can be used, but it requires manual careful configuration to not log certain requests entirely.

For convenience and safe usage of this library, it should by default mark with the label unknown non-standard HTTP methods and User agents to show that such requests were made but do not increase cardinality. In case someone wants to stay with the current behavior, library API should allow to enable it.

The other possibility is to disable HTTP metrics instrumentation by passing otelhttp.WithMeterProvider option with noop.NewMeterProvider.

Solution provided by upgrading

In PR https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277, released with package version 0.44.0, the values collected for attribute http.request.method were changed to be restricted to a set of well-known values and other high cardinality attributes were removed.

References

• https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277
• https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/v1.19.0

Severity

• CVSS Score: 7.5 / 10 (High)
• Vector String: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

References

• https://github.com/open-telemetry/opentelemetry-go-contrib/security/advisories/GHSA-5r5m-65gx-7vrh
• https://github.com/open-telemetry/opentelemetry-go-contrib/security/advisories/GHSA-rcjv-mgp8-qvmr
• https://nvd.nist.gov/vuln/detail/CVE-2023-45142
• https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277
• https://github.com/advisories/GHSA-cg3q-j54f-5p7p
• https://github.com/open-telemetry/opentelemetry-go-contrib
• https://github.com/open-telemetry/opentelemetry-go-contrib/blob/5f7e6ad5a49b45df45f61a1deb29d7f1158032df/instrumentation/net/http/otelhttp/handler.go#L63-L65
• https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/v1.19.0
• https://github.com/open-telemetry/opentelemetry-go/blob/38e1b499c3da3107694ad2660b3888eee9c8b896/semconv/internal/v2/http.go#L223
• https://github.com/open-telemetry/opentelemetry-go/blob/v1.12.0/semconv/internal/v2/http.go#L159
• https://lists.fedoraproject.org/archives/list/[email protected]/message/2UTRJ54INZG3OC2FTAN6AFB2RYNY2GAD

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).

---

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[renovate]

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

• any of the package files in this branch needs updating, or
• the branch becomes conflicted, or
• you click the rebase/retry checkbox if found above, or
• you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: tutorials/whatsup/go.sum

Command failed: go get -d -t ./...
go: -d flag is deprecated. -d=true is a no-op
go: downloading github.com/prometheus/client_golang v1.20.5
go: downloading github.com/bwplotka/tracing-go v0.0.0-20230421061608-abdf862ceccd
go: downloading github.com/efficientgo/core v1.0.0-rc.3
go: downloading github.com/oklog/run v1.1.0
go: downloading github.com/prometheus/common v0.61.0
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading github.com/efficientgo/e2e v0.14.1-0.20230421070206-d72d43f3b937
go: downloading github.com/efficientgo/tools/core v0.0.0-20220225185207-fe763185946b
go: downloading github.com/pkg/errors v0.9.1
go: downloading go.opentelemetry.io/otel v1.18.0
go: downloading go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.6.3
go: downloading go.opentelemetry.io/otel/sdk v1.6.3
go: downloading go.opentelemetry.io/otel/trace v1.18.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.6.3
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.6.3
go: downloading google.golang.org/grpc v1.56.3
go: downloading github.com/felixge/httpsnoop v1.0.3
go: downloading go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.44.0
go: downloading github.com/json-iterator/go v1.1.12
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/cespare/xxhash/v2 v2.3.0
go: downloading github.com/prometheus/client_model v0.6.1
go: downloading github.com/prometheus/procfs v0.15.1
go: downloading golang.org/x/sys v0.28.0
go: downloading google.golang.org/protobuf v1.35.2
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/google/go-cmp v0.6.0
go: downloading github.com/klauspost/compress v1.17.9
go: downloading go.opentelemetry.io/proto/otlp v0.15.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/internal/retry v1.6.3
go: downloading google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1
go: downloading golang.org/x/net v0.32.0
go: downloading github.com/golang/protobuf v1.5.3
go: downloading go.opentelemetry.io/otel/metric v1.18.0
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/modern-go/reflect2 v1.0.2
go: downloading github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822
go: downloading github.com/mwitkow/go-conntrack v0.0.0-20190716064945-2f068394615f
go: downloading golang.org/x/oauth2 v0.24.0
go: downloading github.com/go-logr/logr v1.2.4
go: downloading github.com/go-logr/stdr v1.2.2
go: downloading github.com/cenkalti/backoff/v4 v4.1.2
go: downloading github.com/grpc-ecosystem/grpc-gateway/v2 v2.7.0
go: downloading github.com/jpillora/backoff v1.0.0
go: downloading golang.org/x/text v0.21.0
go: downloading go.opentelemetry.io v0.1.0
go: downloading go.opentelemetry.io/otel/exporters/otlp v0.20.1
go: downloading go.opentelemetry.io/otel v1.35.0
go: github.com/prometheus/client_golang/tutorials/whatsup imports
	github.com/bwplotka/tracing-go/tracing/exporters/otlp imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig imports
	go.opentelemetry.io/otel/exporters/otlp/internal: cannot find module providing package go.opentelemetry.io/otel/exporters/otlp/internal
go: github.com/prometheus/client_golang/tutorials/whatsup imports
	github.com/bwplotka/tracing-go/tracing/exporters/otlp imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig imports
	go.opentelemetry.io/otel/exporters/otlp/internal/envconfig: cannot find module providing package go.opentelemetry.io/otel/exporters/otlp/internal/envconfig