Added parsing of missing values and never clause.#1
Open
dariasor wants to merge 2 commits intoyinlou:masterfrom
Open
Added parsing of missing values and never clause.#1dariasor wants to merge 2 commits intoyinlou:masterfrom
dariasor wants to merge 2 commits intoyinlou:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Yin,
I figured out how to do a proper pull request - here it is.
I've added a few more modifications and it is safe to merge my changes now. By default, missing values are not accepted - if they are present, a message "missing values not allowed" shows up and the code proceeds to crash exactly as it would have done before. In order for missing values to be converted to NaNs, one needs to specifically call InstanceReader.read(...) with an additional flag argument set to true.
Never clause is simply parsed properly now - no side effects, doesn't depend on predictor type. Safe to merge. I haven't changed any code for the actual predictors, they all should work as before.
Let me know if you have any more concerns - I can do further tests or modifications if you want. Otherwise I would appreciate if you approve the pull request before introducing any new changes to mltk.