Add CastOptions for subtitles and custom casting parameters - #3
Merged
Conversation
Introduce a public CastOptions type accepted by cast(), castToDevice() and castLocalFile() (all optional, fully source-compatible): - metadata: verbatim DIDL-Lite override for full control - subtitleUri: attach an external subtitle, emitted both as a standard subtitle res and the Samsung sec:SubtitleUri extension - subtitleMimeType / mimeType / upnpClass: override auto-detected values Also make DeviceDescriptionParser internal (it was accidentally public) and document the new API in both READMEs and the changelog. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CastOptionstype:metadata(verbatim DIDL-Lite override),subtitleUri(external subtitles, emitted as a standard subtitle<res>plus the Samsungsec:SubtitleUriextension),subtitleMimeType,mimeType, andupnpClassoverridescast(),castToDevice()andcastLocalFile()— fully source-compatible for existing callersDeviceDescriptionParseris nowinternal(was accidentally public, part of the visibility complaint in [FEATURE] 能否支持携带字幕地址等自定义参数 #2)[Unreleased]section to CHANGELOG.md (also covers the discovery fixes from 1f702f8)Closes #2
Test plan
./gradlew test lint assembleReleasegreen locally (Java 21 / AGP 8.9.2)subtitleUriagainst a Samsung TV (expectssec:SubtitleUrisupport) and a generic renderer (expects subtitle<res>) — needs real devices