Fix local file server: MIME types, reliable Range seeks, registry bound - #5
Merged
Conversation
- Serve correct MIME types by file extension instead of always application/octet-stream (some TVs reject or mis-handle unknown types) - Loop InputStream.skip until the requested Range offset is reached; skip() may under-skip, which started the stream at the wrong position and corrupted seeked playback - Bound the token registry (LRU, 64 entries): every cast mints a new token and the unbounded map leaked entries for the process lifetime Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application/octet-stream— some TVs refuse unknown content typesInputStream.skip()until the requested Range offset is fully skipped: a singleskip()call may skip fewer bytes than requested, which started the HTTP body at the wrong offset and produced a corrupt stream after a seekTest plan
./gradlew test lint assembleReleasegreen locally